fix: windows support #114
Open
fix: windows support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzuki-shunsuke
added
enhancement
suzuki-shunsuke
force-pushed
the
fix/windows-support
branch
from
6ede720 to
8447f94
Compare
suzuki-shunsuke
force-pushed
the
fix/windows-support
branch
from
8447f94 to
56610e3
Compare
airtonix
reviewed
Jan 3, 2024
| @@ -29,6 +29,11 @@ runs: | |||
| shell: bash | |||
| working-directory: ${{ inputs.working_directory }} | |||
| if: inputs.enable_aqua_install == 'true' | |||
| - run: | | |||
| echo "${AQUA_ROOT_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/aquaproj-aqua}/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append | |||
There was a problem hiding this comment.
this needs to be
Suggested change
| echo "${AQUA_ROOT_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/aquaproj-aqua}/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append | |
| echo "${AQUA_ROOT_DIR:-$env:LOCALAPPDATA/aquaproj-aqua}/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append |
i don't think XDG is a thing on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.